search

ocp-power-demos / sock-shop-demo

A multiarchitecture port of the Sock Shop Microservices application
Apache License 2.0
9 stars 18 forks source link

Parameterize 00-storage-class.yaml #5

Open acancell-redhat opened 2 months ago

acancell-redhat commented 2 months ago

The 00-storage-class.yaml could be parameterized, in order to allow the usage of a storage already present in the cluster

Example of a workaround: rm manifests/overlays/multi-mto/00-storage-class.yaml && \ grep -r nfs-client | awk '{print $1}' | tr -d ':' | xargs -I {} sed -i 's/storageClassName: nfs-client/storageClassName: NFS-CUSTOM-STORAGE/g' {}

prb112 commented 2 months ago

Thanks @acancell-redhat absolutely. Feel free to create a new overlay, or raise a pr/change. we'd happily take it.