search

octatone / reddit.tv

HTML5 and AJAX display of videos from reddit.com to replace reddit.tv. Includes any video embed type from reddit. Only backend is reddit.com's API, everything else is clientside.
http://reddit.tv
MIT License
64 stars 70 forks source link

Spinner in center of video corrupts image #18

Closed starrychloe closed 13 years ago

starrychloe commented 13 years ago

The spinner in the center of the video doesn't go away and it corrupts the display of the video. It should be completely hidden after a video loads (or get rid of it altogether). It causes the center of the video to become blocky and lag and every few seconds the spinner image appears on the video. Google Chrome.

starrychloe commented 13 years ago

This is the problem, in tv.js, line 200, you add .loading class but you never remove it after it has loaded:

$video_embed.addClass('loading'); https://github.com/octatone/reddit.tv/blob/master/js/tv.js#L200

octatone commented 13 years ago

fixed here

https://github.com/octatone/reddit.tv/commit/4c197a370e71e25c6a678cdff2b387fdedf57b99