octokatherine / word-master

A Mastermind-like word guessing game
MIT License
377 stars 238 forks source link

Color Blind Mode #70

Open GabeBillings opened 2 years ago

GabeBillings commented 2 years ago

I tried reading through all the open issues but didn’t see this. I don’t know how many other are in the same boat as me, but the right place/wrong place colors are very similar to me. If I get one of each it’s doable because I can see the contrast between them, but when I get one it’s tough. I’ve taken a screenshot of the key and put it right next to my browser and it’s still very hard.I know there are lots of different color blind folks so it’s hard to know what will work for everyone. In this case I would think black, white and 50% would be great. Adding patterns is good too. Personally switching one out for a blue or something would be fine. I love your game but the colors are killing me.

teleshoes commented 2 years ago

adding a high-value-contrast option should be doable. i have a question, though. would it be acceptable, or even preferable, if instead there was some additional permanent style that didnt rely on color or shade or value? maybe adding a 3px solid black border for correct-placement and dotted (or no border) for right-letter-wrong-placement?

if so, i can open a pr adding styles like these and see if the author likes it. i like the idea of accessible-by-default, but my aesthetic sensibilities are not always on target with others' :)

a

GabeBillings commented 2 years ago

Hey Elliot. Thanks for taking a look at the issue.

The color blind thing is a little weird. I only have my personal experience to go on, and I know that different people see different things. I can say that your idea of the dashed and solid outlines is pretty neat, because that should work for anyone, regardless of which colors work for them or not. The only thing I might to is maybe make the lines a hair thicker, and maybe make the spread of the dashes a little further apart if possible. I've been playing a lot on my phone and when I look at this email on phone vs computer the dots aren't quite as pronounced.

For me, at least, the difference in the three colors on the Wordle color blind mode is blindingly different. But I think the outlines would work well, too. If it were me I'd probably go with whatever was easiest to code. :)

Thanks for checking in.

Gabe

On Wed, Jan 19, 2022 at 9:56 PM Elliot Wolk @.***> wrote:

adding a high-value-contrast option should be doable. i have a question, though. would it be acceptable, or even preferable, if instead there was some additional permanent style that didnt rely on color or shade or value? maybe adding a 3px solid black border for correct-placement and dotted (or no border) for right-letter-wrong-placement?

if so, i can open a pr adding styles like these and see if the author likes it. i like the idea of accessible-by-default, but my aesthetic sensibilities are not always on target with others' :)

[image: a] https://user-images.githubusercontent.com/592062/150281640-da2d5ab1-368e-4478-bcf8-69f7ce71dc98.png

— Reply to this email directly, view it on GitHub https://github.com/octokatherine/word-master/issues/70#issuecomment-1017144652, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXKWKDNK5X5W5BQZWHGGJLTUW6PX5ANCNFSM5MD3GOBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>