search

octree-nn / octformer

OctFormer: Octree-based Transformers for 3D Point Clouds
MIT License
240 stars 17 forks source link

About the use of OctrideMaxPool and OctrideMaxUnpool #27

Closed Dreamxxxxxx closed 3 months ago

Dreamxxxxxx commented 3 months ago

Hello, thank you very much for the author's excellent work. I am very interested in it, When using octree_max_unpool, passing depth+1 in this part of the code will result in a mask exceeding the index of the data when entering octreed_depad, which is an error message. image 1 I will print the shape in octree_depad as shown in the picture. image (2) 3 If I only pass in depth without+1, then there is no such issue, but I am not sure if this is correct? image (4) The following is the code I used in the code for using OctreeMaxPool and OctreeMaxUnpool image (5) image (6)

wang-ps commented 3 months ago

Thank you so much for figuring out this issue @Dreamxxxxxx ! I will check it soon.

wang-ps commented 3 months ago

@Dreamxxxxxx I checked the code just now. I think the code is OK. Its usage can be found here (https://github.com/octree-nn/ocnn-pytorch/blob/master/test/test_octree_pool.py#L33) and here (https://github.com/octree-nn/ocnn-pytorch/blob/master/ocnn/models/segnet.py#L65)