search

ocurrent / docker-base-images

Generate various Docker ocaml images
https://images.ci.ocaml.org
MIT License
29 stars 19 forks source link

Update ocaml-version #299

Closed mtelvers closed 2 months ago

mtelvers commented 2 months ago

Add base images for OCaml 5.3~alpha1 and 5.4

mtelvers commented 2 months ago

5.3.0~alpha1+options failed to build. This is because the beta repo is not included in the Dockerfile.

The decision to include the beta repository is made with this logic:

https://github.com/ocurrent/docker-base-images/blob/28953def3a4eb6bf38635ae086f55fa29b821c3e/src/pipeline.ml#L43-L48

Since 5.3.0~alpha1+options is not included int the list of unreleased_betas, the repository is not added. Only 5.3.0~alpha1 is included.

https://github.com/ocurrent/docker-base-images/blob/86b55f8d508c0cb8decf6d73c7dd5438efae06af/src/pipeline.ml#L44

The patch treats all +options varients as if they were included in the unreleased_betas list.

There is a larger question of whether we should build the variants of the development versions and unreleased betas. Dating back to 2019, we have always built the options of the development versions. Thus, this was continued in the update from earlier this year to build the unreleased_betas.