search

ocurrent / obuilder

Experimental "docker build" alternative using btrfs/zfs snapshots
Apache License 2.0
60 stars 17 forks source link

Add support for FreeBSD #120

Closed kit-ty-kate closed 1 year ago

kit-ty-kate commented 2 years ago

Fixes #109 Requires https://github.com/kit-ty-kate/ocaml-docker-hub/pull/1

TODO:

patricoferris commented 2 years ago

When implementing the (still unmerged) macOS backend, we seemed to have agreed on deciding the sandbox at build time. See question 3 here https://github.com/ocurrent/obuilder/pull/87#issue-1048922366 and also https://github.com/ocurrent/obuilder/pull/87#issuecomment-965379804. I don't know which approach would be best?

kit-ty-kate commented 2 years ago

sure, build-time is fine by me, I'll change it. It was just faster to implement it this way for the PoC

MisterDA commented 2 years ago

When implementing the (still unmerged) macOS backend, we seemed to have agreed on deciding the sandbox at build time. See question 3 here #87 (comment) and also #87 (comment). I don't know which approach would be best?

Haha I just reimplemented the opposite: sandbox selection at runtime. I want to be able to use the Docker backend on Linux too, and now if you select the Docker store it will automatically select the docker "sandbox" too instead of runc. https://github.com/ocurrent/obuilder/pull/75/commits/171b7187aca52f382b638bd2219b04e229acb1ad

kit-ty-kate commented 2 years ago

Haha I just reimplemented the opposite: sandbox selection at runtime. I want to be able to use the Docker backend on Linux too, and now if you select the Docker store it will automatically select the docker "sandbox" too instead of runc. 171b718

That can always be implemented on top of build-time selection. You'd just have to list the available backends at build times instead of just one implementation.

I think both are not exclusive with each other, and on my side it allows us to remove a dependency on extunix

kit-ty-kate commented 2 years ago

This looks great! I was wondering how you're testing it @kit-ty-kate, I could try a similar setup?

it's not working yet. I've only opened the PR to allow for some first-pass reviews. I've only just succeeded pushing a freebsd image to docker hub so far, i still haven't tried pulling it (i'm working on opam today)

tmcgilchrist commented 1 year ago

FreeBSD support added in https://github.com/ocurrent/obuilder/pull/174