search

ocurrent / obuilder

Experimental "docker build" alternative using btrfs/zfs snapshots
Apache License 2.0
60 stars 17 forks source link

Obuilder's Dockerfiles should not continue to blank lines #65

Closed dra27 closed 3 years ago

dra27 commented 3 years ago

Merely picking a recent build from opam-repo-ci, the Dockerfile includes a continuation to a blank line which generates a warning from docker build.

An easy fix for that one is probably just to trim the string - and possibly to reduce (\r?\n) to a single \r?\n?

talex5 commented 3 years ago

Well, it's because opam-repo-ci gives it a command with a blank line at the end. OBuilder's behaviour seems reasonable to me, but Docker's doesn't. It seems to ignore the blank line and act as if the continuation applies to the line after that!

Perhaps it should be an error to attempt to convert such a command to a Dockerfile?

talex5 commented 3 years ago

Closing as I think it's just a special-case of #66 (Dockerfile can't handle newlines in general).