search

ocurrent / obuilder

Experimental "docker build" alternative using btrfs/zfs snapshots
Apache License 2.0
60 stars 17 forks source link

Docker Windows prerequisites & changes #73

Closed MisterDA closed 3 years ago

MisterDA commented 3 years ago

Some prerequisites for the Docker/Windows backend, and changes I gathered whilst working on Obuilder.

MisterDA commented 3 years ago

Thank you for the review. I've removed all the commits that are not related to the Docker/Windows port, in particular the Printf to Fmt which was a gross mistake on my part. I've also addressed all your comments and ran ocp-indent on my changes. Concerning the Sandbox.run ?commit commit, while crafting an answer describing why it was needed, I realized that the problem I was trying to solve -- I want to run jobs in the docker sandbox without "committing" (using the result of the run for the build) -- could be solved in the build.ml file, without the need for that parameter, so I've removed that commit too.

I'm starting to think that it was a bad idea to submit these prerequisites without the big picture, nevertheless your review helped me clean my code and my thoughts.

MisterDA commented 3 years ago

Reading the other PRs, I realized that what I was trying to do with the Allow writing build log to a file descriptor change is what #59 was trying to achieve: I want a file descriptor of the output of a sandbox run so that I can pipe it into another process. I was thinking of reusing the Build_log for that purpose, as the output doesn't need to be logged but just piped.

MisterDA commented 3 years ago

Closing, will repush with all the commits.