Open dsavchenko opened 2 years ago
It's not meant to be! See comment in the PR.
It was missing indeed and the reason was that the folder does contain a directory called ".git" After removing it, i succeed to push this library to github.
It was missing indeed and the reason was that the folder does contain a directory called ".git" After removing it, i succeed to push this library to github.
Wait, but it is now added while building the container https://github.com/oda-hub/frontend-container/blob/a3b13af9db25b1c5ef72fd05249419f69f3da1c0/Dockerfile#L92
If swiftmailer is in mmoda-frontend-drupal
, we do not need it anymore in the container.
Right now, there are too many swiftmailers:
./astrooda/sites/all/libraries/swiftmailer
./astrooda/sites/all/modules/swiftmailer
./astrooda/vendor/swiftmailer
./astrooda/vendor/swiftmailer/swiftmailer
Frontend is configured to use the container-added one https://github.com/oda-hub/frontend-chart/blob/master/make.sh#L236 We should probably use the one @motame added, and set suitable config in https://github.com/oda-hub/mmoda-frontend-db. What do you think?
We should probably use the one @motame added, and set suitable config in https://github.com/oda-hub/mmoda-frontend-db.
With this, there will be no need to run any additional build-time or start-time hooks. I think it's a good way.
frontend-drupal7-for-astrooda/sites/all/libraries/swiftmailer seems to be included as a submodule, but its path is not in .gitmodules, so it is not accessible. Container builds without it, then frontend breaks in some places (e.g. sign-in) with an error