search

oddbit / flutter_facebook_app_events

Flutter Plugin for Facebook App Events
https://pub.dev/packages/facebook_app_events
Apache License 2.0
129 stars 331 forks source link

update iOS and android SDKs to latest version #382

Open Kop3sh opened 1 month ago

Kop3sh commented 1 month ago

bump iOS SDK CoreKit from 17.0.0 to 17.4.0 and FBAudienceNetwork from 6.15.0 to 6.16.0 and android SKD to point to the latest SDK release instead of a static version

antonoddbit commented 4 weeks ago

@Kop3sh We are using static library to prevent issue when there is major change.

Kop3sh commented 4 weeks ago

I guess you are right, My first instinct was doing that because the Meta analytics dashboard displayed an error that said upgrade to facebook SDK 14. and wanted to explore if this might fix it.

Bamschool commented 3 weeks ago

@Kop3sh Did you solve it? I have same error

aghyad97 commented 3 weeks ago

Can we merge this PR please, having the same error

Kop3sh commented 3 weeks ago

@Kop3sh Did you solve it? I have same error

tbh, I haven't had the chance to fully test its impact on a live environment

Bamschool commented 3 weeks ago

@Kop3sh Thank you for answering. Could you please let me know when you are done with the test?

mhmzdev commented 3 weeks ago

Any chance of merging this PR? We are facing error on our live app. I've tried using

  facebook_app_events:
    git:
      url: https://github.com/oddbit/flutter_facebook_app_events
      ref: fix/iOS-issue-0.19.4

But its failing bcz the branch doesn't exists anymore cc: @Kop3sh @antonoddbit

antonoddbit commented 3 weeks ago

@mhmzdev that branch is not exist since it's merged yesterday

Bamschool commented 3 weeks ago

@antonoddbit when can you upload it on package? can I use right now?

mhmzdev commented 3 weeks ago

Is there a way I can use this current PR to get the package? We are having warnings on meta dashboard @antonoddbit

antonoddbit commented 3 weeks ago

@mhmzdev pushing the latest main to pub just now using v0.19.4

Bamschool commented 3 weeks ago

@antonoddbit Can I ask you about AppDelegate.swift?

Do I need to add FBSDKCoreKit.ApplicationDelegate.shared.application( application, didFinishLaunchingWithOptions: launchOptions ) in AppDelegate.swift with facebookappevent package?

antonoddbit commented 3 weeks ago

@Bamschool have you setup your facebook id in your project?

Bamschool commented 3 weeks ago

@antonoddbit Yes, I've done that. I am just curious. Is it unnecessary to add anything to AppDelegate.swift when using Facebook App Events? I am just trying to figure it out. Can initialization be done within Facebook App Events?

Bamschool commented 3 weeks ago

@mhmzdev Can I ask you about AppDelegate.swift?

Do I need to add FBSDKCoreKit.ApplicationDelegate.shared.application( application, didFinishLaunchingWithOptions: launchOptions ) in AppDelegate.swift with facebookappevent package?

mhmzdev commented 3 weeks ago

Naa, m not aware of it @Bamschool I'm just waiting for the 0.19.4 release and then I'll test again.

antonoddbit commented 3 weeks ago

hi @mhmzdev please use ref: 3e4e062 instead of ref: fix/iOS-issue-0.19.4 Sorry I just seen the swift linker issue you mention above: https://stackoverflow.com/questions/79094697/undefined-symbol-swift-force-load-on-flutter-ios

mhmzdev commented 3 weeks ago

@antonoddbit Sure, I was about to move to 0.19.4 on pub.dev. I'll go with the ref you shared above Thanks

Artein commented 3 weeks ago

@antonoddbit, am I getting it right, that after some live testing, this change will become a new version, or do we all have to use that ref?

Bamschool commented 2 weeks ago

It's working now. Actually I just have waited for a week. and it worked.

abhishekbbbbbb commented 2 weeks ago

@Bamschool so can i use the latest version of this plugin i.e 19.0.4 ? (facing same issue, also do i have to add something in appdelegate ?)