oddsdk / odd-app-template

A sveltekit web app template for the ODD SDK.
https://odd-template.fission.app
MIT License
29 stars 10 forks source link

Avivash/59 user settings route #84

Closed avivash closed 2 years ago

avivash commented 2 years ago

NOTE: to keep these PRs more manageable, I'm merging the working branches into each other rather than directly to main

404-related code was reviewed here: https://github.com/webnative-examples/webnative-app-template/pull/85

Description

Adding the user settings route.

This is still WIP because i'm trying to find the best way to handle having System Default as a theme preference. Basically, since the only theme options are light or dark, the radio buttons for those options will be selected if the user's system default is one of those(or i can highlight the System Default option instead, but that means the colour that's equal to the system default won't be selectable), unless i do some fairly hacky stuff in the UI. I want to keep the code fairly lean and reactive, so I'm trying to think through the best way to do it/if it's worth us doing πŸ˜… CC: @depatchedmode

Link to issue

https://github.com/webnative-examples/webnative-app-template/issues/59

Type of change

Please delete options that are not relevant.

Screenshots/Screencaps

https://www.loom.com/share/f6e880661f7e44a0b414ae43fe8c600f

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
webnative-template βœ… Ready (Inspect) Visit Preview Nov 8, 2022 at 5:27PM (UTC)
avivash commented 2 years ago

I've also updated the 404 gif as part of this PR