odoo / o-spreadsheet

Other
195 stars 44 forks source link

[IMP] sort: prevent sorting on range with array formula #5229

Open hokolomopo opened 4 days ago

hokolomopo commented 4 days ago

Description:

[IMP] sort: prevent sorting on range with array formula

Sorting on an array formula does not work since the spreaded values cannot be reordered. But the "sort" button was still enabled, leading to cases where the user tried to sort on an array formula, which would fail without any feedback.

This commits displays a warning message when the user tries to sort on a range with an array formula.

[FIX] sort: use allowDispatch instead of throwing

The sort plugin would throw an error if the sort anchor wasn't in the sort zone, instead of using the standard allowDispatch behaviour of returning a DispatchResult.

Task: 4342539

review checklist

robodoo commented 4 days ago

Pull request status dashboard