odoo / o-spreadsheet

Other
195 stars 44 forks source link

[FW][FIX] clipboard: Fix clipboard cross-browser coverage #5241

Closed fw-bot closed 3 days ago

fw-bot commented 3 days ago

The current implementation of the cross-browser clipboard relies heavily on an API that is currently only available on Chromium based browsers (see table).

There is currently no definitive announce that the feature will be adopted by other browsers (namely FF and Safari) and since the feature is still marked as experimental, it'd be better to rely on a more generic approach.

This revision changes the flow to rely entirely on the text/html mimetype as it is supported by all modern browsers.

Task: 4241877

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

Forward-Port-Of: odoo/o-spreadsheet#5063

robodoo commented 3 days ago

Pull request status dashboard

fw-bot commented 3 days ago

@rrahir @hokolomopo cherrypicking of pull request odoo/o-spreadsheet#5063 failed.

stdout:

Auto-merging src/components/grid/grid.ts
Auto-merging src/helpers/clipboard/navigator_clipboard_wrapper.ts
Auto-merging src/plugins/ui_stateful/clipboard.ts
Auto-merging src/types/commands.ts
Auto-merging tests/clipboard/clipboard_plugin.test.ts
Auto-merging tests/grid/grid_component.test.ts
Auto-merging tests/helpers/ui_helpers.test.ts
Auto-merging tests/menus/menu_items_registry.test.ts
Auto-merging tests/test_helpers/commands_helpers.ts
CONFLICT (content): Merge conflict in tests/test_helpers/commands_helpers.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

rrahir commented 3 days ago

@robodoo r+