search

oemof / feedinlib

This repository contains implementations of photovoltaic models to calculate electricity generation from a pv installation based on given solar radiation. Furthermore it contains all necessary pre-calculations.
MIT License
102 stars 44 forks source link

Removed return value and make target_file positional #67

Closed uvchik closed 3 years ago

uvchik commented 3 years ago

We should convince the users to download the file first and then use it instead of downloading it ever again. So the download function should not return the xarray. Even though the download may take hours so it does not make sense from this point of view.

uvchik commented 3 years ago

I remove some code and did not add a test, so relatively the coverage decreased.

uvchik commented 3 years ago

I added a test and I mocked the download method, because otherwise the test could last an hour.