search

oetiker / rrdtool-1.x

RRDtool 1.x - Round Robin Database
http://www.rrdtool.org
GNU General Public License v2.0
1.02k stars 264 forks source link

php support? #724

Open yarda opened 8 years ago

yarda commented 8 years ago

Hi,

please what's the status of the php support? Is it officially supported by rrdtool upstream? I can see some references to php in documentation and in the upstream spec file, which seems to use php4 bindings from probably Joe Miller and there is yours signature in its head. I am currently unable to find the original source for it (it seems to be named php4-r1190.tar.gz). Also Fedora seems to adopt it. But unfortunately this code seems to break with php7 due to their zend* API changes.

So my question is what's the status of the php support? if a) it's supported - the bindings code should be hosted somewhere and fixed to support php7, the correct links should be added to the rrdtool documentation/spec file if b) it's unsupported - the php leftovers should be cleared from the git

oetiker commented 8 years ago

Hi Yarda, yes the php support is not very clear ... if you would like to contribute an update, I'll be glad to merge it.

yarda commented 8 years ago

Maybe, I could contribute something later. I am Fedora downstream maintainer and I just wanted to know the official status. Regarding php7, I had to disable it in Fedora. But I think that the zend* API shouldn't be hard to patch (although even swig haven't done it yet). Maybe I will look on it later. Is the original php binding code hosted anywhere? I wasn't able to find it (we have it in Fedora sources cache, but the origin is unclear to me).

nirgal commented 5 years ago

@yarda: Maybe the Debian repository can help? https://salsa.debian.org/php-team/pecl/php-rrd I'm using it with php 7.3, and it works fine, even if I miss rrdcached support.

yarda commented 5 years ago

@yarda: Maybe the Debian repository can help? https://salsa.debian.org/php-team/pecl/php-rrd I'm using it with php 7.3, and it works fine, even if I miss rrdcached support.

This is what we switched to in Fedora. I don't know whether its upstream has any intention about merging into rrdtool upstream. So probably this ticket could be now closed, because I am not going to port the original bindings to php7 and I have no affiliation to the php-pecl-rrdtool project, so I cannot push it further.