search

oetterer / BootstrapComponents

Bootstrap Components is a MediaWiki extension that aims to provide editors with an easy access to certain components introduced by Twitter Bootstrap 4.
Other
6 stars 9 forks source link

Create release 5.2.0 #47

Closed malberts closed 4 months ago

malberts commented 7 months ago

Besides the other fixes since 5.1.1, the main reason is to include the newer version of the Bootstrap extension (https://github.com/oetterer/BootstrapComponents/commit/b8bd780564d4c13f553e4ee3239828d4c16af681) in a tagged release.

On the Chameleon/Bootstrap side we want to move ahead with dropping support for older versions of MW and PHP, but right now BootstrapComponents is going to prevent Composer from downloading Bootstrap extension 5.0.0.

This change doesn't cause backward incompatible issues for BootstrapComponents users, it just allows it to also work with the new MW 1.39 / PHP 8.0 only version of the Bootstrap extension.

@oetterer Did you have any other fixes or issues in mind for BootstrapComponents 5.2? I can go ahead and prepare a PR for the release if there are no blockers.

oetterer commented 7 months ago

@malberts thank you very much. I have nothing in the pipeline atm, go ahead!

D3nnis3n commented 5 months ago

I'm currently affected by BootstrapComponents blocking install of the 5.0@dev of chameleon (which is not released yet either, though).

oetterer commented 4 months ago

Working on this

oetterer commented 4 months ago

@D3nnis3n the current master is technically compatible with Bootstrap v5.0.0 which I recon you need for chameleon. If you check out the repo instead of using composer to install BootstrapComponents, you should be fine.

I'm still working on incorporating the changes in the components that come with bootstrap5.

malberts commented 4 months ago

FYI The new Bootstrap extension version 5.0.0 still uses Bootstrap 4.6.2. I realise the version numbering is confusing, but the idea was to create a new major version of the extension in order to remove support for old MW and fix support for new MW. The work to include Bootstrap 5.x in the Bootstrap extension is incomplete. That will likely end up being version 6.x of the extension.

Similarly, Chamelon master branch still uses Bootstrap 4.6.2.

In other words, my original idea was to cut a new release 5.2.0 with no additional code changes in BootstrapComponents, or at least not upgrades to Bootstrap 5 components.

D3nnis3n commented 4 months ago

@D3nnis3n the current master is technically compatible with Bootstrap v5.0.0 which I recon you need for chameleon. If you check out the repo instead of using composer to install BootstrapComponents, you should be fine.

I'm still working on incorporating the changes in the components that come with bootstrap5.

All seems to work fine, thanks :)

oetterer commented 4 months ago

@malberts That is good to know, thanks. Was about to start switching the extension to bootstrap5 and would certainly run in some major headaches, wondering why the new component changes wont work. Then I will do a release 5.2.

oetterer commented 4 months ago

All seems to work fine, thanks :)

Thanks for the feedback!

oetterer commented 4 months ago

closed by 00ca967ee2e4dff1ab7bf834c6769e93ee306ff2