update to rxjs 6.x please!

[damien-CFS]

So we can remove the rxjs-compat package please

[mariusl-a]

+1

[mariusl-a]

Replace imports in ng2-completer.js with:

import { __extends } from 'tslib';
import { ChangeDetectorRef, Component, Directive, ElementRef, EventEmitter, Host, HostListener, Injectable, Input, NgModule, Output, Renderer, TemplateRef, ViewChild, ViewContainerRef, forwardRef } from '@angular/core';
import { Observable as Observable$1, Subject as Subject$1, timer as timer$1 } from 'rxjs';
import { take, map, catchError } from 'rxjs/operators';
import { HttpClient, HttpClientModule } from '@angular/common/http';
import { FormControl, FormsModule, NG_VALUE_ACCESSOR, NgModel } from '@angular/forms';
import { CommonModule } from '@angular/common';

[hughjdavey]

This issue prevents full upgrade to Angular 7. Would a pull request to fix the imports be accepted @oferh?

[ofer-papaya]

do you use the beta version npm install ng2-completer@next? There are still some issues with it so couldn't publish it as latest if someone can verify and issue a PR I'll merge and publish.

[nguyenbathanh]

Any updates on this?

[hughjdavey]

Hi @ofer-papaya I wasn't aware of the beta version thanks for the tip. Using 3.0.0-beta.2 this issue is resolved for me :)

What are the issues preventing you from publishing it as latest?

[404Assassin]

confirming that, as of this writing, the version installed with npm install ng2-completer@next is working with Angular 6

[nguyenbathanh]

Using npm install ng2-completer@next is working for now.

[andy-]

ng2-completer@next has rxjs-compat as dependency, so this is not a real solution

"ng2-completer": { "version": "3.0.0-beta.2", "resolved": "https://opstrax.pkgs.visualstudio.com/_packaging/NG-OPSCORE/npm/registry/ng2-completer/-/ng2-completer-3.0.0-beta.2.tgz", "integrity": "sha512-j2/C9rw7WVDBFHh0zmLGkpvFiH/Adg3mphD8xi78+TO0wv4wi/nscdQxgfnLvAtVFoJ1jlAtUFYFlSP1es94/A==", "requires": { "rxjs-compat": "^6.2.2" }