oferh / ng2-completer

Angular 2 autocomplete component
http://oferh.github.io/ng2-completer/
MIT License
348 stars 171 forks source link

Angular 10 Update Generic type 'ModuleWithProviders' requires 1 type argument(s). #456

Open PauloPeres opened 3 years ago

PauloPeres commented 3 years ago

WHERE: @akveo/ng2-completer/src/modules/ng2-completer.module.d.ts:3:23 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s). 3 static forRoot(): ModuleWithProviders;

According to Angular 10 it's now necessary to have a generic type https://angular.io/guide/migration-module-with-providers

vamidi commented 3 years ago

Hopefully a fix for this soon!

PauloPeres commented 3 years ago

@vamidi sent a pull request but looks like no one answered yet, not sure if this rep has people maintaining.

vamidi commented 3 years ago

So unfortunate that there is no update there are a few frameworks that rely on this.

aaron-harvey commented 3 years ago

I used patch-package with

diff --git a/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts b/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts
index f1dd11a..860a84c 100644
--- a/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts
+++ b/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts
@@ -1,5 +1,5 @@
 import { ModuleWithProviders } from "@angular/core";
 export declare class Ng2CompleterModule {
-    static forRoot(): ModuleWithProviders;
-    static forChild(): ModuleWithProviders;
+    static forRoot(): ModuleWithProviders<Ng2CompleterModule>;
+    static forChild(): ModuleWithProviders<Ng2CompleterModule>;
 }

As a stop gap

Hopefully a more permanent fix is merged soon.

BruneXX commented 3 years ago

Thanks @aaron-harvey that tool is awesome! :)

dilankamr commented 3 years ago

Hi All,

I have forked the project and fixed the issue, If anyone wants the fix, replace your "ng2-completer": "^9.0.1" dependency line in package.json with this line: "ng2-completer": "git+https://github.com/dilankamr/ng2-completer.git"

Or run the command: npm install git+https://github.com/dilankamr/ng2-completer.git --save

And do an npm install.

Then, your project will run nicely without any issue. :)

Thanks