search

oguzhanoztaskin / Gstreamer-H264-Encryption

Experimental GStreamer plugin for encrypting / decrypting H264 streams with AES
https://medium.com/@oguzhanoztaskin/gstreamer-h264-encryption-plugin-cf2c7b43c383
GNU General Public License v3.0
4 stars 1 forks source link

GStreamer minimal required version must be increased up to `1.22` #3

Closed inobelar closed 3 months ago

inobelar commented 3 months ago

Hi! After trying to build library on Ubuntu 22.04.4 LTS with GStreamer 1.20.3 , i spotted the next compilation error:

Gstreamer-H264-Encryption/gst-h264-encryption/src/h264_decrypt.c: In function ‘gst_h264_decrypt_before_nalu_copy’:
Gstreamer-H264-Encryption/gst-h264-encryption/src/h264_decrypt.c:159:31: error: ‘GST_H264_SEI_USER_DATA_UNREGISTERED’ undeclared (first use in this function)
  159 |       if (msg->payloadType == GST_H264_SEI_USER_DATA_UNREGISTERED) {
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Its occured, since GstH264Parser :: GstH264SEIPayloadType::GST_H264_SEI_USER_DATA_UNREGISTERED was added since Gstreamer 1.22.

So, we need to increase minimal required GStreamer version in meson.build (currently there minimal version is 1.19)

oguzhanoztaskin commented 3 months ago

Hi there,

Thank you for your interest in this project.

I tested on 1.22 and saw that writing H264 SEI is not supported yet. According to here, it is added on 1.23.1 as in the screenshot: image

Hence, I updated the minimum required version to 1.23.1 while merging your pull requests.

Best regards,