search

oh-my-fish / oh-my-fish-legacy

Oh My Fish!
MIT License
13 stars 2 forks source link

`omf install URL` should strip package/theme from its name #561

Closed bpinto closed 9 years ago

bpinto commented 9 years ago

$ omf install https://github.com/oh-my-fish/plugin-rbenv Will clone the repo and add it a folder named plugin-rbenv but the folder should be named rbenv as omf will launch an event named init_plugin-rbenv which is unexpected.

bobthecow commented 9 years ago

:+1:

Related: for packages and themes with hyphens in their URL, should the event name be converted to underscore?

bpinto commented 9 years ago

I think this would be unexpected, why do you think we should convert it?

bobthecow commented 9 years ago

just because it's ugly :P

it's fine, leave it as-is.

bpinto commented 9 years ago

:D