search

oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.
MIT License
1.46k stars 225 forks source link

Update check for nvm to allow for functions #295

Closed nathan-gilbert closed 3 years ago

nathan-gilbert commented 3 years ago

After the latest change allowing for NVM or FNM, my prompt decorations for NVM are broken.

I use https://github.com/FabioAntunes/fish-nvm and have used methods like https://eshlox.net/2019/01/27/how-to-use-nvm-with-fish-shell to get NVM to play nice with Fish and Bob The Fish. Using the -f flag on type means these methods are not able to determine when NVM is being used.

I'm not sure this is the best way to get prompt functionality back -- but it solves the issue of ignoring NVM declared as a function.

bobthecow commented 3 years ago

Sure, this is fine.

Before it just checked for the environment variable. Now, because we're trying to distinguish between the flavors, we actually look at nvm itself, so it's more strict.