search

oh-my-fish / theme-budspencer

A theme for nerds, makes fish even more powerful. It's equipped with a hell of a lot of nice functions and key bindings to speed up your workflow.
MIT License
106 stars 42 forks source link

theme-budspencer does not get installed correctly #88

Open TriplEight opened 2 years ago

TriplEight commented 2 years ago

It's either not complete installation guide or broken installation script.

after omf install budspencer my terminal is blocked with an error:

fish: Unknown command: __budspencer_preexec

To override the error and make the commands be executed I had to enter Ctrl + j every time.

To make the theme working I had to copy https://github.com/oh-my-fish/theme-budspencer/blob/master/functions/fish_prompt.fish script into my ~/.config/fish/functions/fish_prompt.fish.

Also, it's not aware if svn is not installed and it seems like a mandatory requirement.

clayauld commented 2 years ago

svn is a requirement due to a recent addition.

After running omf install budspencer you will have to run exec fish to reload the settings. Does that fix your issue? the __budspencer_preexec error is relatively common if you don't reload fish after the install.

TriplEight commented 2 years ago

I couldn't execute anything in the terminal while having that error.

To override the error and make the commands be executed I had to enter Ctrl + j every time.

Is it possible to place a conditional test in the installation, so it fails with an error if there's no svn installed?

ethsol commented 1 year ago

svn is a requirement due to a recent addition.

After running omf install budspencer you will have to run exec fish to reload the settings. Does that fix your issue? the __budspencer_preexec error is relatively common if you don't reload fish after the install.

I don't have svn and not intend to install it, so after trying to install theme-budspencer I simply cannot use fish. Terminal doesn't execute any command. Ctrl J doesn't help either. I had to uninstall it using a hack:

bash $ mv ~/.local/share/omf/themes/budspencer{,.NOTHERE}
bash $ fish
fish $ omf remove budspencer.NOTHERE

In case svn is a requirement please modify the install or main script to have a check whether svn is installed.