search

ohai / ruby-sdl2

A Ruby wrapper for SDL 2.x
GNU Lesser General Public License v3.0
71 stars 16 forks source link

Support SDL_mixer >= 2.0.2 #8

Closed ged closed 6 years ago

ged commented 6 years ago

This patch adds support for versions of SDL_mixer 2.0.2 and later, which removed the MIX_INIT_MODPLUG and MIX_INIT_FLUIDSYTH constants, and added MIX_INIT_MID.

I implemented this using have_const and the extconf.h that Mkmf can generate so it'll keep working under earlier versions, but I'm sure there are better ways to do this. I'm not at all familiar with M4, or I'd have attempted to use that instead to follow the project's conventions a bit more closely.

I also included some Rake tasks for clean and clobber in a separate commit that made it easier to rebuild it cleanly under various Ruby versions in case they might be useful; you should of course feel free to discard whatever you want from this PR.

Thanks again for a great library!

ohai commented 6 years ago

Thank you for your PR. I accept it.

comment: The change of Rakefile should be separated into another pull request since the purpose of the two commits are different. If you have another chance of pull request, please be more careful.

ged commented 6 years ago

That makes sense. Sorry for being lazy, and thanks for accepting this!