search

ohmage / gwt-front-end

The javascript/GWT code behind the front end.
6 stars 2 forks source link

Mobility data from other timezones is not rendered correctly #281

Open cketcham opened 11 years ago

cketcham commented 11 years ago

Because the first 3 hours of data (from 12am to 3am EST) is technically the day before (9pm to 12am PST) the data is not being rendered in the mobility visualization.

Should we ignore the current timezone and just show show the data from the perspective of the user who collected it? Or should we adjust the data for the timezone? If we adjust the data to use the timezone, we need to fix this bug so it shows data from the end of the previous day in cases like this.

Screen Shot 2013-03-05 at 11 33 42 AM

jojenki commented 11 years ago

How did you test this? I am wondering how you know the data exists and who isn't making it available. The server should already have provisions for this, so the call to mobility/read with a date of, say, "2012-12-03" should return all Mobility points for that day as the user experienced them. However, I feel that it would be odd for the front end to remove these points of the server returned them...

cketcham commented 11 years ago

I checked the points in the db. I'm not sure if the server just isn't returning the correct points, or the frontend isn't rendering them correctly though.

jshslsky commented 11 years ago

It looks like the problem here is that the front-end is just using the browser's time zone.