ohmtech-rdi / eurorack-blocks

Software to Hardware Prototyping for Eurorack using C++, Max/Gen~ or Faust
Other
293 stars 19 forks source link

Fix widget to param id binding #646

Closed ohmtech-rdi closed 6 months ago

ohmtech-rdi commented 6 months ago

This PR fixes a bug for EncoderButton where all the controls declared after an EncoderButton would be wrongly binded to their parameter in VCV Rack representation.

This is because we didn't take into account the abstraction changes we made in replace_config_controls_bind and replicate them in replace_controls_widget. We were using the number of pins for the Lights, only, and that so happen to work for LEDs but not for other controls.