Cross chunk protections should apply to other deposit kinds.

oitsjustjose / Geolosys

A logical, geological system in Minecraft

GNU General Public License v3.0

42 stars 36 forks source link

Cross chunk protections should apply to other deposit kinds. #286

Closed Rosethorns closed 2 years ago

Rosethorns commented 2 years ago

Versions:

Minecraft Forge: 38.0.15
Geolosys: 1.18
JourneyMap (optional):
ImmersiveEngineering (optional):

What happens: chunk holes in deposit_layer style deposits

What should happen:

Should form deposits uniformly across chunks as it does with deposit_sparse

Logs (if necessary):

Additional Comments:

While the risk of cascading worldgen is a possibility, a deposits size is predictable and cascading worldgen therefore manageable.

oitsjustjose commented 2 years ago

All plutons (in fact, even samples) use cross-chunk protection. I think I have fixed this issue, but do let me know if you in fact continue to have this issue in 7.0.0-alpha2. Below is a screenshot where the chunk I'm standing in is where the pluton started. I set it up to use a huge radius (19) and happened across this one after some heavy refactoring.

oitsjustjose commented 2 years ago

Possibly fixed in d0adc49cd6f488c063b1aadf05138a9980be2f47