ojosproject / website

The Ojos Project website containing our blogs and documentation!
https://ojosproject.org/
GNU General Public License v3.0
0 stars 0 forks source link

Remove `react-embed` as a dependency #26

Closed calejvaldez closed 2 months ago

calejvaldez commented 2 months ago

Summary

react-embed seems to try to be an "all in one" embed component for React. However, it seems like it's just bloating the website and causing unnecessary dependency conflicts. Maybe use something smaller, like react-embed-figma, depending on how the dependencies react.

What is the expected correct behavior?

N/A

Steps to reproduce

N/A

Relevant logs and/or screenshots

react-embed repo source code showing various different components. It also hasn't had any releases since July 4, 2023.

Logs when running npm i:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-instagram-embed@1.5.0
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   react@"^18.0.0" from the root project
npm WARN   50 more (@docsearch/react, @docusaurus/core, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.0.0 || ^15.0.0 || ~0.14.0" from react-instagram-embed@1.5.0
npm WARN node_modules/react-embed/node_modules/react-instagram-embed
npm WARN   react-instagram-embed@"^1.5.0" from react-embed@3.7.0
npm WARN   node_modules/react-embed
npm WARN 
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@"^16.0.0 || ^15.0.0 || ~0.14.0" from react-instagram-embed@1.5.0
npm WARN   node_modules/react-embed/node_modules/react-instagram-embed
npm WARN     react-instagram-embed@"^1.5.0" from react-embed@3.7.0
npm WARN     node_modules/react-embed
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-instagram-embed@1.5.0
npm WARN Found: react-dom@18.2.0
npm WARN node_modules/react-dom
npm WARN   react-dom@"^18.0.0" from the root project
npm WARN   37 more (@docsearch/react, @docusaurus/core, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"^16.0.0 || ^15.0.0 || ~0.14.0" from react-instagram-embed@1.5.0
npm WARN node_modules/react-embed/node_modules/react-instagram-embed
npm WARN   react-instagram-embed@"^1.5.0" from react-embed@3.7.0
npm WARN   node_modules/react-embed
npm WARN 
npm WARN Conflicting peer dependency: react-dom@16.14.0
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"^16.0.0 || ^15.0.0 || ~0.14.0" from react-instagram-embed@1.5.0
npm WARN   node_modules/react-embed/node_modules/react-instagram-embed
npm WARN     react-instagram-embed@"^1.5.0" from react-embed@3.7.0
npm WARN     node_modules/react-embed
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility

added 1364 packages, and audited 1365 packages in 9s

319 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Operating System

macOS

Browser

Other

calejvaldez commented 2 months ago

added in 4dfc4491fbd2349a9121fe633613e5ecdb672491