search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
329 stars 43 forks source link

#2164 - Keep payments info when switching between pledger and receiver #2268

Closed SebinSong closed 1 month ago

SebinSong commented 1 month ago

closes #2164

SebinSong commented 1 month ago

@taoeffect This PR is ready besides the heisenbug with the group-chat test suite. (which passes when I run the test locally)

cypress[bot] commented 1 month ago

Passing run #2858 ↗︎

0 112 10 0 Flakiness 0

Details:

Merge c40829768a43103b939f62557b72259321dc0fde into ad6aedbd5be6f3c615808fdec8c5...
Project: group-income Commit: e0c7cfd479 ℹ️
Status: Passed Duration: 10:31 💡
Started: Jul 29, 2024 5:23 AM Ended: Jul 29, 2024 5:33 AM

Review all test suite changes for PR #2268 ↗︎

SebinSong commented 1 month ago

@taoeffect

  1. The pie chart is broken

image

This is screenshot where I tried the same scenario (Assuming the group's mincome is 1000 and the only member of the group is a receiver with 500 as the income) in master. The pie chart looks the same there.

  1. Did you test whether the changes persist across distribution periods?

Yes it works in that scenario too.