okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
329 stars 43 forks source link

Picture viewer #2347

Open taoeffect opened 1 week ago

taoeffect commented 1 week ago

Problem

We don't have a way to zoom the pictures to view them more closely.

Solution

Create a picture viewer so that when a picture attachment clicked (or tapped) then it is shown in a view in more detail similar to how other apps do it.

On mobile it should be very simple - simply make the picture full screen and make it possible to pinch to zoom in and out.

SebinSong commented 2 days ago

@taoeffect I'm referencing Slack's image viewer and it has 200% as the maximum zoom-in limit for all cases, regardless of how big/small the intrinsic image size is.

image

That's when it's viewed on desktop and on mobile-app it seems to allows more zoom-in (it's not sure as it doesn't show the in-app slider UI on mobile-app but it feels like 300 or 400%).

What do we want as the maximum value in our app?

taoeffect commented 2 days ago

Let's go with 400% and if you feel that doesn't work well feel free to pick a value that you like better