Closed oddlittlebird closed 5 years ago
Yes, that was my mistake. 1313 was blank, and when I started editing the file in VSC, it opened the file in 8090.
On Fri, Sep 13, 2019 at 5:54 AM Mahdi Pourismaiel notifications@github.com wrote:
@mpourismaiel requested changes on this pull request.
Fantastic. It might need a small change.
In README.md https://github.com/okkur/syna-start/pull/17#discussion_r324178486:
@@ -50,3 +55,7 @@ images in their own fragment directory, page directory and
static/images
directory. Read our image fallthrough documentation for more info.Further details read our full documentation. + +## First Steps + +Open index.md and type. The changes are visible almost immediately at http://localhost:8090/.
Isn't the default port 1313?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/okkur/syna-start/pull/17?email_source=notifications&email_token=AMNF6KOSTIOZWS7EGNWWLLLQJOERLA5CNFSM4IWHOLXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEVHX3Y#pullrequestreview-287996911, or mute the thread https://github.com/notifications/unsubscribe-auth/AMNF6KIDCXY3DRY7IXF5SYLQJOERLANCNFSM4IWHOLXA .
So please change the port and we'll merge it right away.
Done, I think. I made the change and committed it.
On Sat, Sep 14, 2019 at 3:43 AM Mahdi Pourismaiel notifications@github.com wrote:
So please change the port and we'll merge it right away.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/okkur/syna-start/pull/17?email_source=notifications&email_token=AMNF6KMOERFNZPX4NS23DETQJS53JA5CNFSM4IWHOLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WZKBQ#issuecomment-531469574, or mute the thread https://github.com/notifications/unsubscribe-auth/AMNF6KJDFGFTOL2YKOHH5PTQJS53JANCNFSM4IWHOLXA .
Awesome thanks \o/
Added prerequisites and clarified some content. Started a First Steps section, which should be expanded in the future.
Needs more information about what to do once you get it up and working. I added content to index.md, now it is displaying:
+++ url = "/" title = "Syna Theme" date = "2017-09-07" description = "Open Source Theme from Okkur for your next project" +++
Heading 1
If you want new Hugo users to be successful, I recommend adding instructions so they can at least get a "Hello, World!" on the first page. Maybe give them a clue where to find layouts, too.