search

okonek / tidal-cli-client

You can now use Tidal on linux. With your loved CLI. <3
MIT License
272 stars 29 forks source link

Breaking API changes with Node-MPV 2 #33

Open j-holub opened 6 years ago

j-holub commented 6 years ago

Hey there,

I'm the author of Node-MPV. Thanks a lot for using it 🙂

I've been working on a Version 2 of the library for quite a while now and I think I will publish it to NPM within the next days or weeks. Version 2 brings quite some changes to the table as it makes heavy use of promises to check if all the messages it sends to MPV over the socket are actually working or not.

You can find Version 2 here along with a Migration Guide and the Changelog.

I'm just filing this issue to inform you, that you either want to lock the Node-MPV version in your package.json or if you are willing to take the time, migrate your app to version 2, as soon as it is released. I try to provide bugfixes for Version 1 in the future but I will probably not add new features. I think version 2 is a lot more robust and overall better so you might at least want to take a look 🙂

Cheers

okonek commented 6 years ago

Thank you very much for your help. I'll try to rewrite my Player to match the new version 2 api in a few days.

j-holub commented 6 years ago

Cool 🙂 Just keep in mind that as long as I haven't merged the branch into master and published it on NPM yet, everything is still subject to change. I don't think I'll change anything big but just keep in mind I might :)

okonek commented 6 years ago

Yeah, thank you :)