okta / okta-sdk-dotnet

A .NET SDK for interacting with the Okta management API, enabling server-side code to manage Okta users, groups, applications, and more.
Other
160 stars 100 forks source link

Make IDP Discovery Rule Application Id property non-readonly #716

Closed pdubb29 closed 5 months ago

pdubb29 commented 6 months ago

Summary

Updated the discovery rule application id property to be non-readonly. We are using this library to create idp discovery rules. When we set the property Type of AppAndInstanceConditionEvaluatorAppOrInstance and call the api, we get an error that says the Id property of the app must be set. With this ID property being readonly, we are unable to send that to the api.

Fixes: N/A

Type of PR

Test Information

.NET Version: .NET 8 Os Version: Windows 10

Signoff

ReadonlyProperty

Exception is thrown when I attempt to create a policy rule without the id field being set: await _policyApiAsync.CreatePolicyRuleAsync(...);

Okta.Sdk.Client.ApiException: 'Error calling CreatePolicyRule: {"errorCode":"E0000001","errorSummary":"Api validation failed: conditions.app","errorLink":"E0000001","errorId":"oaeWdhyrRMnRmS4h6LAslVS6g","errorCauses":[{"errorSummary":"conditions.app: The condition 'app' requires an 'id' value if the type is APP."},{"errorSummary":"conditions.app: The condition 'app' requires an 'id' value if the type is APP."}]}'

laura-rodriguez commented 6 months ago

Thanks for your contribution @pdubb29! We'll have to port your PR to the OpenAPI spec and regenerate the SDK. I filed an internal ticket to be reviewed by the team.

Internal Ref: https://oktainc.atlassian.net/browse/OKTA-732080

pdubb29 commented 6 months ago

I see this got merged in, do you want me to close this now?