search

okta / okta-signin-widget

HTML/CSS/JS widget that provides out-of-the-box authentication UX for your organization's apps
Other
375 stars 317 forks source link

Remove jQuery from Sign-in Widget code #512

Open nbarbettini opened 6 years ago

nbarbettini commented 6 years ago

Currently, jQuery is included in this package for a few different reasons:

  1. Internal dependency in the Courage framework (which the Sign-in Widget vendors)
  2. Internal dependency in Auth.js (this will be removed soon, tracked in https://github.com/okta/okta-auth-js/issues/144)
  3. Making HTTP calls with $.ajax from the Sign-in Widget
  4. DOM manipulation

1 is outside of the control of this library currently. However, 3 and 4 can be cleaned up:

aarongranick-okta commented 4 years ago

Removes jQuery from unit tests, updates AuthJS: https://github.com/okta/okta-signin-widget/pull/1080