Fix "malformed package" error when using watch mode

oleavr / frida-agent-example

Example Frida agent written in TypeScript

https://www.frida.re/

726 stars 182 forks source link

Fix "malformed package" error when using watch mode #27

Closed Gbps closed 11 months ago

Gbps commented 2 years ago

Hi there,

In the latest version of this repo, using "npm run watch" fails to generate a proper Gum package with error "malformed package" during injection. I narrowed this down to the fact that the watch command was not using "-c" which enables compression. This PR adds that flag to the script.

Best,

Gbps

nblog commented 1 year ago

I offer a different view that I think watch when it may be under DEBUG may be more needed for a better code preview, and when you are sure to use build after RELEASE, it may be better to get a streamlined code.

oleavr commented 11 months ago

Thanks! This is unfortunately a symptom of a bug elsewhere, so the proposed solution here is a workaround. I don't think we should make this change, as it's typically preferable to disable compression in watch mode, so line numbers in stack traces are more reliable.