search

olefredrik / FoundationPress

FoundationPress is a WordPress starter theme based on Foundation 6 by Zurb
https://foundationpress.olefredrik.com
MIT License
2.7k stars 869 forks source link

Gulp task for pot generation #1356

Open derweili opened 5 years ago

derweili commented 5 years ago

We should implement a process for generating a pot file.

I think we can implement this by using this package https://github.com/rasmusbe/gulp-wp-pot

derweili commented 5 years ago

I implemented a solution in 94e4852e9afb224b43fa2497f68601565f567dfb

checkout the pot-task branch

Unfortunately the gulp-wp-pot requires node > 8 which does not comply with our current requirements (node > 6.11).

I think this should be implemented after the whole build process has beeen refactored.

kLOsk commented 5 years ago

Excellent! I was looking further at parcel.js and think it might not be q goid solution for us. It automates a lot u der the hood, but because of this it also makes advanced features like the pot file generation or text-domain rename rather difficult. I still have some issues with babel (es6) vs es5. I'm somewhat opting for rewriting the whole gulpfile to es5, just so its easier to understand when looking at the gulp docs, that said es6 in general is actually easier than es5... You have any opinion towards it?

On Mon, Feb 4, 2019, 11:30 PM Julian Weiland notifications@github.com wrote:

I implemented a solution in 94e4852 https://github.com/olefredrik/FoundationPress/commit/94e4852e9afb224b43fa2497f68601565f567dfb

checkout the pot-task http:///olefredrik/FoundationPress/tree/pot-task branch

Unfortunately the gulp-wp-pot requires node > 8 which does not comply with our current requirements (node > 6.11).

I think this should be implemented after the whole build process has beeen refactored.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/olefredrik/FoundationPress/issues/1356#issuecomment-460269263, or mute the thread https://github.com/notifications/unsubscribe-auth/ACiK3CB4V-713AWbB0hBmsgQIHYVsYb1ks5vKEQNgaJpZM4aWLH- .

derweili commented 5 years ago

@kLOsk I would prefer ES6 over ES5.

What are the issuees with ES6?

kLOsk commented 5 years ago

It's just that the official Gulp documentation has all examples in ES5 and it's somewhat difficult to follow our gulp file if you are unaware of the differences. We should make a note in the gulpfile that it's using ES6 and point to some ES6 docs I think.