search

oleg-shilo / wixsharp

Framework for building a complete MSI or WiX source code by using script files written with C# syntax.
MIT License
1.12k stars 175 forks source link

Simplify Custom UI - remove Caliburn.Micro #1638

Open oleg-shilo opened 2 months ago

oleg-shilo commented 2 months ago

Discussed in https://github.com/oleg-shilo/wixsharp/discussions/1631

Originally posted by **smaudet** September 10, 2024 Question/suggestion, What is Caliburn Micro really providing? Can we just get rid of it? Possibly it is just the difficulty of debugging UI at an admin level in a mixed-mode setting, possibly it is that windows forms + wpf is just bugged, but Caliburn seems like it is adding another layer of (unwelcome) complexity to the insanity of a stack that is MSI... As mentioned in another discussion here previously, there is something wrong with the hosted WPF, where under the right circumstances the wpf window can't initialize correctly. Well, now the features dialog has gone and broken (some update, and I was making updates to my installer). Maybe there is some better way of debugging what is happening in the WPF/WinForms that stuff like bindings don't work and I can't inspect the UI at all (with snoop/microsoft blend, it all crashes and burns horribly), but it seems like Caliburn is just some ancient library that doesn't provide much except another layer of hell to debug...
Torchok19081986 commented 2 months ago

very good idea, oleg. Seems right way. I use in my wpf apps, community toolkit for WPF from MS. Also Avalonia UI with MVVM is good for WPF and C# , if it somehow possible to add it to WPF Custom UI Template, would be awesome.

oleg-shilo commented 2 months ago

Mind you you can use any MVVM now, even without removing Caliburn. I will; be removing it not to create new opportunities for users but to avoid dependency and possible runtime side effects.