search

olexale / arkit_flutter_plugin

ARKit Flutter Plugin
MIT License
790 stars 223 forks source link

Added features to load models from .gltf and .glb files. #211

Closed Jaemin-VIRNECT closed 8 months ago

Jaemin-VIRNECT commented 9 months ago

Added features to load models from .gltf and .glb files. (using GLTFSceneKit)

And examples also added.

olexale commented 9 months ago

Hello @Jaemin-VIRNECT,

Thank you so much for this PR! I'll review it on the weekend and if everything is good publish a new version. Meanwhile, could you please make sure you are not using "print" in the production code and that all files are formatted? Was there a reason to bump the minimum SDK version?

Thanks again!

Kind regards, Oleksandr

Jaemin-VIRNECT commented 9 months ago

Hello @olexale , Thank you for your quick reply and great work. All dart files have their code formatted according to Android Studio default settings.

I checked my PR again and it seems that my NodeBuilder.swift is using the print(). After a quick review of your code it seems I should have used logPluginError().

If there is a problem with the file format, etc., would you please change it? (I am a beginner in Swift. :( )

And about the minimum SDK version, Enum.name requires a minimum SDK version >= 2.15.0 (Android Studio warning).

olexale commented 8 months ago

Thanks again, @Jaemin-VIRNECT! I'll make some clean up (unrelated to your changes) in the plugin and release a new version with your contribution soon!

olexale commented 8 months ago

I just pushed version 1.0.7 with your changes. Thanks!

Jaemin-VIRNECT commented 8 months ago

Thank you so much! @olexale