search

olimorris / neotest-phpunit

🧪 Neotest adapter for PHPUnit
MIT License
29 stars 22 forks source link

refactor(command): use artisan test if Laravel project #8

Closed saifulapm closed 2 years ago

saifulapm commented 2 years ago

In addition to the phpunit command, we ca use the test Artisan command to run your tests for Laravel. The Artisan test runner provides verbose test reports in order to ease development and debugging

olimorris commented 2 years ago

Appreciate this and thanks for the PR.

One thought I have, would it be easier to allow someone to define this in their own Neotest config rather than bake it into the plugin?

olimorris commented 2 years ago

Hey @saifulapm. Your PR inspired me to add configuration option for the phpunit executable (ca4724c08933fc2ec0f5797d4ecfd161c1da4a91).

I'm keen to not bake too much opinionated logic into the adapter so would prefer users to configure it for themselves. Your brilliant PR could hopefully live in your Neotest config.

What do you think?

saifulapm commented 2 years ago

Yes. That will be great if it's configurable. I was just testing artisan test because artisan output more nice. Thank you

olimorris commented 2 years ago

Please play around and let me know how it works. I've documented it in the readme too.