olimorris / onedarkpro.nvim

🎨 Atom's iconic One Dark theme. Cacheable, fully customisable, Tree-sitter and LSP semantic token support. Comes with variants
MIT License
821 stars 47 forks source link

[Bug]: control+c will close neovim #151

Closed YosefRohanP closed 1 year ago

YosefRohanP commented 1 year ago

Your OneDarkPro config

  onedarkpro.setup({
    -- Your onedarkpro config here
  })
  vim.cmd("colorscheme onedark")

Error messages

No response

Describe the bug

in windows, if you click control+c, it will actually quit neovim, instead of returning to normal mode.

image

image

Reproduce the bug

control+c it starts from this commit https://github.com/olimorris/onedarkpro.nvim/commit/55a5af203541ddf29993758e4b7d4d95cbba72ad

Final checks

olimorris commented 1 year ago

I haven't actually tested on Windows so cannot say with 100% certainty, but I'd be amazed if this commit is causing Neovim to crash or exit. Have you really tested with the minimal config I provided?

I map <C-c> in my config with no issues.

If you can provide a minimal.lua file to test with I'll see if I can recreate it.

YosefRohanP commented 1 year ago

not sure if this is related, but sometimes it shows this just for a split second before neovim started Untitled

YosefRohanP commented 1 year ago

I haven't actually tested on Windows so cannot say with 100% certainty, but I'd be amazed if this commit is causing Neovim to crash or exit. Have you really tested with the minimal config I provided?

I map <C-c> in my config with no issues.

If you can provide a minimal.lua file to test with I'll see if I can recreate it.

I have already tested it with minimal.lua, the only things I changed in it was the 'ensure_installed = "all"'

YosefRohanP commented 1 year ago

I found this bug in December, but I just put this in my packer config.

commit = "6f13896727c82c1ff56acf483d474ba7ad88f230"
olimorris commented 1 year ago

I've just pushed a fix (61b4f4509a59247118ff93f1707f41d4674a5ac2) which I hope stops the a subdirectory or file [xxxxxxx] already exists. Can you let me know if that works?

YosefRohanP commented 1 year ago

the message is gone, thank you!

YosefRohanP commented 1 year ago

but weirdly, it also fixes the control+c problem, thank you!

olimorris commented 1 year ago

Glad to hear and thanks for raising!