search

oll3 / bita

Differential file synchronization over http
https://crates.io/crates/bita
MIT License
265 stars 10 forks source link

Commit code generated by prost-build #41

Closed MCOfficer closed 7 months ago

MCOfficer commented 8 months ago

Since v0.11 (4fea65bc82e33acd18e2f48c7f4e52384c06c995), prost-build requires protoc to be installed while compiling. This means any downstream application / library of bitar also needs it to compile.

Seeing how "the new recommendation for libraries is to commit their generated protobuf" (https://github.com/tokio-rs/prost/pull/657), it's probably best for bitar to ship the generated code, rather than generating it at compile-time.

oll3 commented 7 months ago

Since v0.11 (4fea65b), prost-build requires protoc to be installed while compiling. This means any downstream application / library of bitar also needs it to compile.

Seeing how "the new recommendation for libraries is to commit their generated protobuf" (tokio-rs/prost#657), it's probably best for bitar to ship the generated code, rather than generating it at compile-time.

Sure, seems reasonable to include the source. I guess we would regenerate it manually if wanted and then remove bitar/build.rs. Would you like to create a PR?

MCOfficer commented 7 months ago

I'll look into it.