ollm / OpenComic

Comic and Manga reader, written with Node.js and using Electron
GNU General Public License v3.0
941 stars 80 forks source link

[Suggestion]: UI improvment #271

Closed dajotim937 closed 1 month ago

dajotim937 commented 1 month ago

Preflight Checklist

Describe your suggested feature

  1. Set a minimum size of thumb of scrollbar in chapter viewer, so it won't be 3px unseeable dot. Maybe also consider to set a minimum site of thumb of scrollbar from sidebar with page previews on the left side of viewer. Not that I had a small thumb there but just in case.
    Screenshot

image

  1. Putting libary link in url here (screenshot). I don't know about others users, but in my case usually when I end read chapter and want to switch, I don't need to switch to other chapter, I usually switch to other manga from library. Probably library link in url is needed only when chapter is open. In other cases library buttor from sidebar is visible
    Screenshot

image

  1. Kinda bug, I guess. Remove duplicates from url history for back button (screenshot). Right now, for example from screenshot, you can click 5 times on c053.cbz link and when you click "back" it will return 4 times to same c053.cbz folder and only 5th click on back button will return you to chapter viewer.
    Screenshot

image

Additional Information

No response

Sample file

No response

ollm commented 1 month ago

Thanks for the suggestions.

I have set a minimum scrollbar size of 60px, this applies to all scrollbars. I have also added the possibility of showing the library in the header (it has to be enabled from settings), although there is currently a bug and it is that it is also shown if it is opened from master folders, labels, etc.

Build: https://mega.nz/file/WTo1FRDJ#49VUmqrkLj6SxS3SuuzZxGc4a1J2F1ZvHuxlXtQTEtg

dajotim937 commented 1 month ago

Min height of scrollbar thumb and duplicates to the url history is indeed works. However, library link in header is not present for me: image

ollm commented 1 month ago

Have you enabled it in the settings?

Captura desde 2024-09-27 20-47-22 Captura desde 2024-09-27 20-48-52

dajotim937 commented 1 month ago

Oh, yeah. Somehow missed that. Sorry. Yep, working fine.

ollm commented 1 month ago

Closed as completed and available in v1.3.0

dajotim937 commented 2 weeks ago

Found a bug with "library" in header: if you drag&drop folder outside of master folder and open them (open choice when drag&drop, not add one), then "library" doesn't appear in header.

ollm commented 2 weeks ago

At the moment this is the expected behavior, it only shows if you open it from the library, labels, servers, etc, but not when you open a file via Drag and Drop or Open file dialog, in these cases only the name of the file and the go back button are displayed.

I think showing the Library in header could cause confusion, as it might give the impression that the file is in it when it is not.