ollm / OpenComic

Comic and Manga reader, written with Node.js and using Electron
GNU General Public License v3.0
955 stars 80 forks source link

[Feature Request]: Option to stop "Play background music" #298

Open pein0saga opened 2 days ago

pein0saga commented 2 days ago

Preflight Checklist

Describe your suggested feature

It is quite annoying that "Play background music" is a default action. Users should have right to know that opencomic has this feature opened. Most people don't know this and will think this is a bug.

I usually need to open a cbz file in a folder which has all kinds of files including audio media.

Please give us a option to turn this off.

I found this function in https://github.com/ollm/OpenComic/issues/261.

I think "Play music in background in the folder" should not be turned on when most people don't know.

Additional Information

No response

Sample file

No response

ollm commented 2 days ago

The option can be disabled with the icon that appears when music is present, it is a global option (like the magnifying glass) so it will apply to all folders.

Captura desde 2024-11-29 17-55-00

If you think that's better, I can change the default option for new installations to false. https://github.com/ollm/OpenComic/blob/342c9feea652fab1fa4444e07a7dc32afaa859e3/scripts/storage.js#L151-L154

pein0saga commented 8 hours ago

change the default option for new installations to false

I think "change the default option for new installations to false" is better. Most people don't know this hidden function, and I find this owing to it played scary audio when I didn't want to

ollm commented 8 hours ago

You are right, it is better to activate it expressly if you want to use it (Mainly for Webtoons https://github.com/ollm/OpenComic/issues/149), I have changed it to false and the change will be in the next version b6346a71d77b735b3383a5ffd475d807134f53c3