search

olsh / todoist-net

A Todoist API client for .NET written in C#
MIT License
70 stars 15 forks source link

Migrate from Newtonsoft.Json to System.Text.Json #48

Closed splendid25 closed 6 months ago

splendid25 commented 8 months ago

Hello,

I'm trying to use this library in a .NET8 AOT app, but it seems the Newtonsoft.Json is not compatible with AOT. Is a migration planned in the netstandard2 version of the library, to use the more recent System.Text.Json ?

I took a quick look, and there are a few uses of JsonConverter and DefaultContractResolver that can't be migrated as is.

olsh commented 8 months ago

Hi

Is a migration planned in the netstandard2 version of the library, to use the more recent System.Text.Json ?

Nothing is planned at the moment, since I don't have a lot of time to work on the project. But it would be nice to migrate to System.Text.Json. PR is welcome.

splendid25 commented 6 months ago

Awesome work, thank you ! I meant to take a shot at this, but didn't have time yet :)