Documentation clarification: SOCIAL_AUTH_FORCE_POST_DISCONNECT

omab / django-social-auth

Django social authentication made simple

https://groups.google.com/group/django-social-auth

BSD 3-Clause "New" or "Revised" License

2.65k stars 756 forks source link

Documentation clarification: SOCIAL_AUTH_FORCE_POST_DISCONNECT #759

Closed kaleissin closed 11 years ago

kaleissin commented 11 years ago

If SOCIAL_AUTH_FORCE_POST_DISCONNECT is set to True but a POST is not used, the result is a white page; no disconnect, no error messages. It would be better if this resulted in a 500 with an appropriate error-message or a 405, but describing what happens where social_disconnect* is docced would also help.

omab commented 11 years ago

The view returns a 405 error code (it's triggered by django require_POST decorator).

omab commented 11 years ago

405

kaleissin commented 11 years ago

.. and you have to read the source of decorators.py to see that, preferrably the source to require_POST too. It should be documented.

omab commented 11 years ago

Reading source code is a common task, anyway, I've added doc regarding the 405 response code.