search

omcljs / om

ClojureScript interface to Facebook's React
6.66k stars 362 forks source link

Use react-create-class since React.createClass is deprecated #883

Closed wilkerlucio closed 6 years ago

wilkerlucio commented 7 years ago

Closes #881

dehli commented 6 years ago

I did some investigating last night about this (thanks for the tips @wilkerlucio!) and I've started to come up with an alternative solution here. The advantage would be that we wouldn't have to pull in create-react-class. Note my fork doesn't address line 903 in core.cljs. I need to spend some more time going through the code base to figure that out.

However, as I was reading through the code I realized that defui is just a React.Component class so maybe we could use that here instead (with some refactoring)?

swannodette commented 6 years ago

Hrm shouldn't this PR bump the other React deps?

wilkerlucio commented 6 years ago

@swannodette React 16 is still in beta, you want that to be upgraded? I just used the createClass from 16 because that was the latest (and I don't think that matters much for this plugin). If you want I can upgrade React to beta, or downgrade the create-react-class to 15.5.3-0, what you think?

anmonteiro commented 6 years ago

Superseded by #892

anmonteiro commented 6 years ago

Closing