Closed sbesson closed 2 years ago
Automated Review URLs
Argh. Again not working.
Otherwise, :+1: though I agree that the schema name is not particularly friendly.
Otherwise, ๐ though I agree that the schema name is not particularly friendly.
Open to alternative suggestions but my concern is that this might force us to modify the name of existing published schemas - https://github.com/ome/ngff/tree/main/0.4/schemas.
LGTM ๐
Re the remaining sticking point (the name), considering simply naming the schemas as label.schema
and strict_label.schema
.
Those names sound fine to me ๐
@sbesson : is it fair to say that this "fixes #125" as well?
Yes and furthermore it only fixes #125. The previous description was erroneous (now updated)
Fixes #125
This PR reviews the
image-label
specification and brings it inline with recent improvements made to other specifications including:In addition to reviewing the validation tests keep passing and that the modified text is sensible, the two biggest changes that should be reviewed, notably by the original authors of the specification (all marked as reviewers of this PR) are:
colors
andproperties
keys with no requirement level and does not define theversion
key. In addiition to clarifying the expected content, this PR proposes a set of requirement levels using the keywords from RFC2119 and implemented through the JSON schemasstrict_image-label.schema
to follow the convention used for other JSON schemas while keeping the hyphen separator using inimage-label
. The mixture of underscore and hyphen is most likely confusing. Should we change to underscores? Update (2022-07-05): updated the proposal to uselabel.schema
andstrict_label.schema