ome / ngff

Next-generation file format (NGFF) specifications for storing bioimaging data in the cloud.
https://ngff.openmicroscopy.org
Other
119 stars 41 forks source link

image-label: JSON schemas and clarifications #130

Closed sbesson closed 2 years ago

sbesson commented 2 years ago

Fixes #125

This PR reviews the image-label specification and brings it inline with recent improvements made to other specifications including:

In addition to reviewing the validation tests keep passing and that the modified text is sensible, the two biggest changes that should be reviewed, notably by the original authors of the specification (all marked as reviewers of this PR) are:

github-actions[bot] commented 2 years ago

Automated Review URLs

joshmoore commented 2 years ago

Automated Review URLs

Argh. Again not working.

Otherwise, :+1: though I agree that the schema name is not particularly friendly.

sbesson commented 2 years ago

Otherwise, ๐Ÿ‘ though I agree that the schema name is not particularly friendly.

Open to alternative suggestions but my concern is that this might force us to modify the name of existing published schemas - https://github.com/ome/ngff/tree/main/0.4/schemas.

will-moore commented 2 years ago

LGTM ๐Ÿ‘

sbesson commented 2 years ago

Re the remaining sticking point (the name), considering simply naming the schemas as label.schema and strict_label.schema.

will-moore commented 2 years ago

Those names sound fine to me ๐Ÿ‘

joshmoore commented 2 years ago

@sbesson : is it fair to say that this "fixes #125" as well?

sbesson commented 2 years ago

Yes and furthermore it only fixes #125. The previous description was erroneous (now updated)