search

ome / omero-blitz

Gradle project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
0 stars 15 forks source link

Implement setROIName in OMEROMetadataStoreClient #90

Closed melissalinkert closed 4 years ago

melissalinkert commented 4 years ago

Importing an OME-TIFF file that defines an ROI with the Name attribute set currently results in the name being lost. This change should make it so that the ROI name is correctly saved during import.

I'd guess this was just an oversight when names were added in https://github.com/ome/openmicroscopy/pull/3362, but if there is a reason why the name can't be passed through then happy to discuss alternatives.

A minimal pyramid OME-TIFF with one named ROI is in /uod/idr/scratch/inbox/with-roi.ome.tiff.

chris-allan commented 4 years ago

Do we need to do anything else on this PR or can it be merged, @sbesson?

/cc @joshmoore, @jburel

jburel commented 4 years ago

Looks good. iviewer RFE created https://github.com/ome/omero-iviewer/issues/326