search

ome / omero-cli-transfer

An OMERO CLI plugin for creating transfer packets between OMERO servers.
https://pypi.org/project/omero-cli-transfer/
GNU General Public License v2.0
16 stars 14 forks source link

remove twine #44

Closed jburel closed 1 year ago

jburel commented 1 year ago

This proposed changes match the approach used in other Python repositories

no other Python repos use testpypi. This could be removed if we agree Also I would suggest to use the common secret to push to pypi (commit not pushed). Any objections?

will-moore commented 1 year ago

I'm not a great reviewer here since I'm not familiar with the build (or twine). Is it tested in any way, or does it need a release before we run it?

jburel commented 1 year ago

see for example https://github.com/ome/omero-cli-render/blob/master/.github/workflows/publish_pypi.yml

erickmartins commented 1 year ago

happy to bring it in line with other OME releases. I think it will require a new release before it runs, but it's a pretty simple workflow and should just work.

I have some time slotted for working on cli-transfer in the coming weeks that will hopefully lead to a new release. Merging this for now.

erickmartins commented 1 year ago

Well, it seems like there's a syntax error on the workflow file. @jburel can you have a look at that?

erickmartins commented 1 year ago

(FWIW it looks like an indentation error)