ome / omero-insight

Gradle project containing insight java client for OMERO
https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 14 forks source link

Fix posix issue #418

Closed jburel closed 8 months ago

jburel commented 8 months ago

2 tests are currently failing on Windows see https://github.com/ome/omero-insight/pull/416 with the error

java.lang.UnsupportedOperationException: 'posix:permissions' not supported as initial attribute
        at sun.nio.fs.WindowsSecurityDescriptor.fromAttribute(WindowsSecurityDescriptor.java:358)
        at sun.nio.fs.WindowsFileSystemProvider.createDirectory(WindowsFileSystemProvider.java:492)
        at java.nio.file.Files.createDirectory(Files.java:674)
        at java.nio.file.TempFileHelper.create(TempFileHelper.java:136)
        at java.nio.file.TempFileHelper.createTempDirectory(TempFileHelper.java:173)
        at java.nio.file.Files.createTempDirectory(Files.java:950)
        at com.google.common.io.TempFileCreator$JavaNioCreator.createTempDir(TempFileCreator.java:102)
        at com.google.common.io.Files.createTempDir(Files.java:439)

This PR replaces the usage of com.google.common.io.Files directly by java.nio.file.Files. This PR is required to release a new version of omero-insigth

dominikl commented 8 months ago

Trying to test this with the Insight merge build, but can't run it. Any ideas? Thought it might just be on OSX, but also got the same on Linux VM, running Java 11:

~/Downloads/OMERO.insight-5.8.4-SNAPSHOT/bin$ ./omero-insight
Error: LinkageError occurred while loading main class org.openmicroscopy.shoola.Main
    java.lang.ExceptionInInitializerError: null

~/Downloads/OMERO.insight-5.8.4-SNAPSHOT/bin$ java --version
openjdk 11.0.21 2023-10-17
OpenJDK Runtime Environment (build 11.0.21+9)
OpenJDK 64-Bit Server VM (build 11.0.21+9, mixed mode)
dominikl commented 8 months ago

I'll just build/run it from your branch for now.

pwalczysko commented 8 months ago

Tested download and upload of a file with @dominikl 's local build from this PR. I have the same problem as @dominikl with the merge-ci artifact.

lgtm and the test is green

jburel commented 8 months ago

Maybe a problem with merge-ci. Maybe some PR that should not be included are included. We have seen that previously