search

ome / omero-test-infra

Test infrastructure for decoupled repositories
BSD 2-Clause "Simplified" License
3 stars 13 forks source link

Do we want to enforce maintainers to have packaging configuration? #71

Open marimeireles opened 2 months ago

marimeireles commented 2 months ago

I'm trying to setup omero-test-infra in a repository that is not set up to be a python package. Currently, omero-test-infra requires to be set-up in a repository that contains pyproject.toml or setup.py. Is that a feature or a bug? It might be good to make project maintainers to setup packages if they want to use this setup, but I'm wondering if that's what we want to do.

marimeireles commented 2 months ago

Another issue that comes to mind is whether all applications what will depend on this repo are python apps?

jburel commented 2 months ago

This was mainly developed for our needs and for the needs of members of the community building either Web apps or CLI plugins. Some steps requiring setup.py could easily be ignored depending on the repository using it. What is the setup of your repository?

marimeireles commented 2 weeks ago

It's a bit specific and a bit uncommon I think, but I'm creating an extension for OMERO that uses ontop. And then got prompted about needing a config file for Python, which didn't make sense in my case, but then I imagined it might be other users since there's a big overlap of this ecosystem with Java, for example.

jburel commented 2 weeks ago

Which "stage" are you passing to the test-infra srv and dev do not run Python commands

joshmoore commented 2 weeks ago

It might well be that the ontop use case (https://github.com/German-BioImaging/omero-ontop-mappings) needs another stage, @marimeireles like service. i.e., you're going somewhere where no one has gone before ;)

That could possibly then use the docker-compose.yml in your repository as an extension of the main one. That might help to get rid of some of the diff in https://github.com/ome/omero-test-infra/compare/master...marimeireles:omero-test-infra:master

cc: @cfgrote